fix: upgrade svelte-check preventing unmet peer deps errors #13103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
valentinpalkovic
force-pushed
the
valentin/upgrade-svelte-check-in-svelte-ts-sandbox
branch
2 times, most recently
from
69f2be3
to
f66c7ad
Compare
valentinpalkovic
force-pushed
the
valentin/upgrade-svelte-check-in-svelte-ts-sandbox
branch
from
f66c7ad
to
105e0b7
Compare
The svelte-ts template installs Typescript in v5.x, although svelte-preprocess, which is defined as v4.x and is a dependency of svelte-check, does not mention Typescript 5 as a valid peer dependency. Bumping svelte-check to v3 resolves the issue, because then svelte-preprocess v5 is used under the hood, which defines Typescript 5 as a valid peer dependency. Package managers, which throw an error for unmet peer dependencies, will not fail anymore.
valentinpalkovic
force-pushed
the
valentin/upgrade-svelte-check-in-svelte-ts-sandbox
branch
from
105e0b7
to
fbd7d51
Compare
5 tasks
valentinpalkovic
changed the title
valentinpalkovic
changed the title
valentinpalkovic
changed the title
patak-dev
approved these changes
May 5, 2023
dominikg
approved these changes
May 5, 2023
valentinpalkovic
deleted the
valentin/upgrade-svelte-check-in-svelte-ts-sandbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The svelte-ts template installs Typescript in v5.x, although svelte-preprocess, which is defined as v4.x and is a dependency of svelte-check, does not mention Typescript 5 as a valid peer dependency. Bumping svelte-check to v3 resolves the issue, because then svelte-preprocess v5 is used under the hood, which defines Typescript 5 as a valid peer dependency. Package managers, which throw an error for unmet peer dependencies, will not fail anymore.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).