Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust child process I/O for compodoc command #22441

Merged
merged 1 commit into from
May 11, 2023
Merged

Adjust child process I/O for compodoc command #22441

merged 1 commit into from
May 11, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #22400

What I did

Refactor package manager's runPackageCommand method to include an optional stdio parameter for better control over child process I/O

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this May 8, 2023
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label May 8, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from 7713e00 to c3aad06 Compare May 8, 2023 09:58
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from c3aad06 to ef3d574 Compare May 11, 2023 07:26
@valentinpalkovic
Refactor package manager's runPackageCommand method to include an opt…
99eb500 
…ional stdio parameter for better control over child process I/O
@valentinpalkovic valentinpalkovic force-pushed the valentin/excessive-compodoc-output branch from ef3d574 to 99eb500 Compare May 11, 2023 07:51
yannbf
yannbf approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you plan on patching this?

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 11, 2023
@valentinpalkovic valentinpalkovic merged commit e1be2e8 into next May 11, 2023
17 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/excessive-compodoc-output branch May 11, 2023 08:54
@shilman shilman mentioned this pull request May 11, 2023
Closed
shilman pushed a commit that referenced this pull request May 22, 2023
@valentinpalkovic @shilman
Merge pull request #22441 from storybookjs/valentin/excessive-compodo…
8631b6a 
…c-output

Adjust child process I/O for compodoc command
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
@shilman shilman mentioned this pull request May 22, 2023
Merged
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
angular bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook fails to build on large Angular projects due to excessive Compodoc output
3 participants
@valentinpalkovic @yannbf @shilman