Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: move builders #22751

Merged
merged 5 commits into from May 26, 2023
Merged

Build: move builders #22751

merged 5 commits into from May 26, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 24, 2023

I've moved 3 packages into their own subdir (a child directory of code) for organizational purposes.

The 3 packages I moved:

lib/builder-manager ➡️ builders/builder-manager
lib/builder-vite ➡️ builders/builder-vite
lib/builder-webpack5 ➡️ builders/builder-webpack5

Having the builders all in the same place will make it easier to focus on builder work, and the builders won't be a bit of a distraction when coding on other lib/* packages.

Any code-changes in this PR are only to make tools such as eslint, etc, and CI understand where the code moved to.

@ndelangen ndelangen self-assigned this May 24, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label May 24, 2023
@ndelangen ndelangen requested a review from JReinhold May 25, 2023 06:54
@storybookjs storybookjs deleted a comment from socket-security bot May 26, 2023
@socket-security
Copy link

socket-security bot commented May 26, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@storybook/ember@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +21/-51 shilman
@storybook/cli@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +14/-108 shilman
@storybook/addon-docs@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +54/-150 shilman
storybook@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +60/-436 shilman
@storybook/server-webpack5@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +28/-58 shilman
@storybook/server@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +7/-21 shilman
@storybook/addon-storysource@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +11/-17 shilman
@storybook/addon-highlight@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +12/-28 shilman
@storybook/preview-web@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +6/-15 shilman
@storybook/addons@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +9/-13 shilman
@storybook/addon-essentials@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +27/-60 shilman
@storybook/addon-controls@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +28/-90 shilman
@storybook/node-logger@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +0/-0 shilman
@storybook/components@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +4/-5 shilman
@storybook/addon-links@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +18/-28 shilman
@storybook/addon-actions@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +20/-32 shilman
@storybook/theming@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +1/-4 shilman
@storybook/addon-backgrounds@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +20/-30 shilman
@storybook/react-webpack5@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +50/-110 shilman
@storybook/react@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +22/-96 shilman
@storybook/addon-viewport@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +10/-15 shilman
@storybook/addon-a11y@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +22/-40 shilman
@storybook/source-loader@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +2/-1 shilman
@storybook/blocks@7.1.0-alpha.24 7.0.0-alpha.43...7.1.0-alpha.24 None +13/-44 shilman

# Conflicts:
#	code/yarn.lock
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see a few places where "lib/build*" is present, mostly in test-storybooks, which I'm not sure matters? but the docs entry should probably be updated.
image

@ndelangen
Copy link
Member Author

Those lockfiles... yeah I have no idea how to generate those.. I don't know how to even use those projects.. But whoever finds out will at least have correct package.json files.

maybe @tmeasday or @shilman knows what the status of those test-storybook/*directories are?

@JReinhold JReinhold self-requested a review May 26, 2023 20:51
@ndelangen ndelangen merged commit 606b167 into next May 26, 2023
56 checks passed
@ndelangen ndelangen deleted the norbert/move-builders branch May 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants