Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook CLI for angular: dev dependencies and fix addon-notes usage #2572

Merged
merged 4 commits into from
Dec 27, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 27, 2017

Issue: #2569

What I did

  • Angular CLI was missing some NPM dependencies that I had to install by hand. Added these to the CLI.
  • Fixed the notes example installed by the CLI

How to test

ng new angular-test
cd angular-test/
/path/to/storybook/lib/cli/bin/index.js
yarn run storybook

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested a review from a team December 27, 2017 01:00
@tmeasday
Copy link
Member

LGTM

@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #2572 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2572   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files         398      398           
  Lines        8838     8838           
  Branches      942      966   +24     
=======================================
  Hits         2889     2889           
+ Misses       5304     5257   -47     
- Partials      645      692   +47
Impacted Files Coverage Δ
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
...tories_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
...s/actions/src/lib/types/function/createFunction.js 53.33% <0%> (ø) ⬆️
addons/actions/src/lib/types/function/index.js 77.77% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
addons/viewport/src/components/viewportInfo.js 36.36% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813654e...803e7fa. Read the comment docs.

@shilman shilman changed the title Add necessary dev dependencies to Angular CLI Fix storybook CLI for angular: dev dependencies and fix addon-notes usage Dec 27, 2017
@shilman shilman merged commit 596e30b into master Dec 27, 2017
@shilman shilman deleted the shilman/fix-angular-cli branch December 27, 2017 02:12
'@storybook/addon-notes',
'@storybook/addon-actions',
'@storybook/addon-links',
'@types/lodash-es'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still needed, given that we've reverted #2558 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants