Storyshots integrity tests options #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
added
addon: storyshots
patch:yes
igor-dv
requested review from
alexandrebodin,
alterx,
danielduan,
Hypnosphi,
ndelangen,
thomasbertet and
usulpro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
=========================================
Coverage ? 36.83%
=========================================
Files ? 459
Lines ? 10053
Branches ? 904
=========================================
Hits ? 3703
Misses ? 5808
Partials ? 542
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Apr 15, 2018
Hypnosphi
added
the
patch:done
Hypnosphi
added a commit
that referenced
this pull request
Apr 17, 2018
…ixes Storyshots integrity tests options # Conflicts: # addons/storyshots/src/index.js
This was referenced Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: "Integrity tests - Abandoned Storyshots" tests are checking that every snapshot (storyshot) matches its story file. Basically, this is needed only for multisnapshots tests. This test is working with
glob, and it is very slow because glob is just searching in every place (and in the monorepos it even slower)#3301, #3290
What I did
Disabled this test by default, and provided an "integrityOptions" option that is actually a glob settings parameter.
TBD: add to readme