Force re-render event #3515
Merged
Force re-render event #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
alterx,
danielduan,
Gongreg,
igor-dv,
ndelangen,
rmevans9 and
tmeasday
as code owners
tmeasday
approved these changes
Apr 30, 2018
lib/core/src/client/preview/start.js
Outdated
| @@ -170,6 +171,10 @@ export default function start(render, { decorateStory } = {}) { | |||
|
|
|||
| renderUI(); | |||
| reduxStore.subscribe(renderUI); | |||
| const forceReRender = () => renderUI(true); | |||
| if (isBrowser) { | |||
| channel.on(Events.FORCE_RE_RENDER, () => renderUI(true)); | |||
There was a problem hiding this comment.
Use the forceRerender const here?
igor-dv
approved these changes
May 1, 2018
ndelangen
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1736 introduced an ability to force rerender story, but you have to depend on a particular framework to use it. I've introduced a
'forceReRender'event that addons could use in a framework-agnostic way.This also introduces constants for core events as a separate package (to avoid circular dependency between
coreandui)