Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyshots advanced config options #3747

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jun 10, 2018

Issue: #3260

This PR is rebased on "storyshots-refactoring" branch because I didn't want to wait for the #3745 to be merged.

What I did

  1. Added an option to configure storybook inside the storyshot test.
  2. configPath were only able to point on config dir, now it can also point on config.js
  3. Added an optional parameter for the test functions to prevent using them like this : multiSnapshotWithOptions({})

@codecov
Copy link

codecov bot commented Jun 11, 2018

Codecov Report

Merging #3747 into storyshots-refactoring will increase coverage by 0.06%.
The diff coverage is 55.81%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           storyshots-refactoring    #3747      +/-   ##
==========================================================
+ Coverage                   41.53%   41.59%   +0.06%     
==========================================================
  Files                         461      462       +1     
  Lines                        5128     5147      +19     
  Branches                      860      866       +6     
==========================================================
+ Hits                         2130     2141      +11     
- Misses                       2483     2490       +7     
- Partials                      515      516       +1
Impacted Files Coverage Δ
...s/storyshots-core/src/frameworks/angular/loader.js 11.11% <0%> (-1.39%) ⬇️
...hots/storyshots-core/src/frameworks/html/loader.js 12.5% <0%> (-1.79%) ⬇️
...shots/storyshots-core/src/frameworks/vue/loader.js 0% <0%> (ø) ⬆️
...yshots/storyshots-core/src/frameworks/rn/loader.js 0% <0%> (ø) ⬆️
...yshots/storyshots-core/src/frameworks/configure.js 100% <100%> (ø)
...ots/storyshots-core/src/frameworks/react/loader.js 100% <100%> (ø) ⬆️
...ts/storyshots-core/src/frameworks/config-loader.js 100% <100%> (ø) ⬆️
...dons/storyshots/storyshots-core/src/test-bodies.js 90.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45a3cc...1a9a227. Read the comment docs.

@igor-dv igor-dv changed the base branch from storyshots-refactoring to master June 12, 2018 18:35
@igor-dv igor-dv merged commit 86f37eb into master Jun 12, 2018
@igor-dv igor-dv deleted the storyshots-advanced-config branch June 12, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants