Fix non-polyfilled themed UI components #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
Hypnosphi,
igor-dv,
ndelangen and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3829 +/- ##
==========================================
+ Coverage 41.31% 41.35% +0.04%
==========================================
Files 455 455
Lines 5182 5184 +2
Branches 900 900
==========================================
+ Hits 2141 2144 +3
+ Misses 2497 2496 -1
Partials 544 544
Continue to review full report at Codecov.
|
|
I'm guessing @Hypnosphi is right, if the reference to the theme doesn't change then a PureComponent is slightly better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3825
What I did
There were a couple components that did not use
react-lifecycle-compatpolyfills and broke theming for React v16.3 (?) and below. Added in the needed polyfills.How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]