Storyshots puppeteer images do not match #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelog
requested review from
alterx,
Hypnosphi,
igor-dv,
thomasbertet and
tmeasday
as code owners
markelog
force-pushed
the
storyshots-puppeteer-images-do-not-match
branch
4 times, most recently
from
3bfa468
to
015e881
Compare
markelog
changed the title
markelog
changed the title
|
CI and danger failures seems unrelated to the changes? |
|
Looks like you've branched from the wrong place. Can you please merge from master? |
When current screenshots do not much with previous ones, we show connection error since `expect` method also throws. Workaround that and also lowercase the error message so it would look like more then other errors Fixes storybookjs#4036
markelog
force-pushed
the
storyshots-puppeteer-images-do-not-match
branch
from
015e881
to
bf90ac0
Compare
|
Done |
igor-dv
approved these changes
Aug 17, 2018
igor-dv
changed the base branch from
master
to
storyshots-puppeteer-images-do-not-match
|
I've rebased it on another branch, maybe it will fix the CI 🤷♂️ |
igor-dv
merged commit 9ca612f
into
storybookjs:storyshots-puppeteer-images-do-not-match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When current screenshots do not much with previous ones,
we show connection error since
expectmethod also throws.Workaround that and also lowercase the error message so it would look
like more then other errors
Fixes #4036