riot tag loader missing in cli #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libetl
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4122 +/- ##
=======================================
Coverage 40.46% 40.46%
=======================================
Files 491 491
Lines 5835 5835
Branches 793 793
=======================================
Hits 2361 2361
Misses 3085 3085
Partials 389 389Continue to review full report at Codecov.
|
libetl
force-pushed
the
bugfix/riot-tag-loader-missing-in-cli
branch
from
d257498
to
e914243
Compare
libetl
force-pushed
the
bugfix/riot-tag-loader-missing-in-cli
branch
from
903a49e
to
baa809c
Compare
ndelangen
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
added automatic adding of riot-tag-loader in devDependencies while using
getstorybook --riotHow to test
Is this testable with Jest or Chromatic screenshots? no
Does this need a new example in the kitchen sink apps? no
Does this need an update to the documentation? no
If your answer is yes to any of these, please make sure to include it in your PR.