Updated installation for Angular #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel-core needs to be @babel-core
westandy-dcp
requested review from
Hypnosphi,
ndelangen and
shilman
as code owners
Generated by 🚫 dangerJS |
igor-dv
reviewed
Oct 7, 2018
|
|
||
| Next, install `@storybook/angular` and `babel-core` (it's a peerDependency) to your project: | ||
| Next, install `@storybook/angular` and `@babel/core` (it's a peerDependency) to your project: |
There was a problem hiding this comment.
You should probably also mention babel-loader@8 here.
Codecov Report
@@ Coverage Diff @@
## master #4302 +/- ##
======================================
Coverage 40.2% 40.2%
======================================
Files 510 510
Lines 5945 5945
Branches 794 794
======================================
Hits 2390 2390
Misses 3170 3170
Partials 385 385Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-core needs to be @babel-core
Issue:
What I did
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]