Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject webpack-related issues #4883

Merged
merged 1 commit into from Nov 29, 2018
Merged

Reject webpack-related issues #4883

merged 1 commit into from Nov 29, 2018

Conversation

ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Nov 28, 2018

The Problem

If there is a webpack-related issue, you won't be able to see it, and instead, you'll see the following error:

image

Which does not help with finding the solution to the problem.


The err object will not include compilation errors and those must be handled separately using stats.hasErrors() which will be covered in detail in Error Handling section of this guide. The err object will only contain webpack-related issues, such as misconfiguration, etc.

From webpack docs


The Solution

When there is an error, reject it instead of the stats.

@igor-dv igor-dv added bug configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 29, 2018
Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #4883 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4883      +/-   ##
==========================================
- Coverage   35.22%   35.21%   -0.02%     
==========================================
  Files         564      564              
  Lines        6929     6931       +2     
  Branches      930      931       +1     
==========================================
  Hits         2441     2441              
- Misses       3995     3996       +1     
- Partials      493      494       +1
Impacted Files Coverage Δ
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd81aa...a376473. Read the comment docs.

@igor-dv igor-dv merged commit 587e825 into storybookjs:next Nov 29, 2018
@ranyitz ranyitz deleted the show-webpack-related-issues branch November 29, 2018 16:01
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants