Improve typings of theming lib #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
commented
Mar 9, 2019
gaetanmaisse
commented
Mar 9, 2019
gaetanmaisse
added
ci: do not merge
help wanted
and removed
ci: do not merge
help wanted
labels
Exported `styled` was implicitly of type `CreateStyled<any>`, now it is typed using SB Theme. This stronger typing reveals a missing `bar` property in background default object.
gaetanmaisse
requested review from
Hypnosphi,
igor-dv and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## next #5988 +/- ##
=======================================
Coverage 34.92% 34.92%
=======================================
Files 648 648
Lines 9517 9517
Branches 1352 1381 +29
=======================================
Hits 3324 3324
Misses 5576 5576
Partials 617 617
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Exported
styledwas implicitly of typeCreateStyled<any>, now it is typed using SB Theme.This stronger typing reveals an invalid property use in a11y addon.
How to test
SB must compile.