Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regexp in config.js #6180

Merged
merged 1 commit into from
Mar 21, 2019
Merged

fix: regexp in config.js #6180

merged 1 commit into from
Mar 21, 2019

Conversation

Means88
Copy link
Contributor

@Means88 Means88 commented Mar 19, 2019

Issue: #6179

What I did

Add escape to dot in regex.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    I don't know how to test it with Jest.
  • Does this need a new example in the kitchen sink apps?
    No.
  • Does this need an update to the documentation?
    Yes, and it has updated in this PR.

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #6180 into next will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #6180     +/-   ##
=========================================
+ Coverage   37.93%   38.04%   +0.1%     
=========================================
  Files         645      643      -2     
  Lines        9626     9420    -206     
  Branches      352     1344    +992     
=========================================
- Hits         3652     3584     -68     
+ Misses       5927     5268    -659     
- Partials       47      568    +521
Impacted Files Coverage Δ
lib/ui/src/settings/shortcuts_page.js 0% <0%> (-25%) ⬇️
lib/ui/src/containers/panel.js 14.28% <0%> (-19.05%) ⬇️
lib/ui/src/containers/nav.js 11.76% <0%> (-4.91%) ⬇️
addons/notes/src/Panel.tsx 39.62% <0%> (-4.28%) ⬇️
app/polymer/src/client/index.js 0% <0%> (ø) ⬆️
app/html/standalone.js 0% <0%> (ø) ⬆️
lib/core/src/server/config.js 0% <0%> (ø) ⬆️
lib/core/src/server/cli/prod.js 0% <0%> (ø) ⬆️
addons/storysource/src/preview.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/OneOf.js 60% <0%> (ø) ⬆️
... and 227 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b8243...d3dd74c. Read the comment docs.

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core addon: storyshots cli and removed core labels Mar 19, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- LGTM!

@shilman shilman added this to the 5.0.x milestone Mar 19, 2019
@ndelangen ndelangen merged commit edd4f48 into storybookjs:next Mar 21, 2019
shilman pushed a commit that referenced this pull request Mar 23, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: storyshots bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants