Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds an example of a boolean knob #6242

Merged
merged 2 commits into from Mar 25, 2019
Merged

adds an example of a boolean knob #6242

merged 2 commits into from Mar 25, 2019

Conversation

ariesshrimp
Copy link
Contributor

proves that the boolean knob works as expected

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

proves that the boolean knob works as expected
@shilman shilman added addon: knobs maintenance User-facing maintenance tasks labels Mar 23, 2019
@shilman shilman modified the milestones: 5.0.x, v5.1.0 Mar 23, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @joefraley Is this currently working? Or did you add it to show that knobs boolean is broken?

As an aside, most of the time we look at official-storybook. Never hurts to add an example to a specific view layer tho.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #6242 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6242   +/-   ##
=======================================
  Coverage   38.12%   38.12%           
=======================================
  Files         645      645           
  Lines        9647     9647           
  Branches      355      355           
=======================================
  Hits         3678     3678           
  Misses       5914     5914           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f01fb8...213e91d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #6242 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6242   +/-   ##
=======================================
  Coverage   38.12%   38.12%           
=======================================
  Files         645      645           
  Lines        9647     9647           
  Branches      355      355           
=======================================
  Hits         3678     3678           
  Misses       5914     5914           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f01fb8...5091cd2. Read the comment docs.

@ndelangen ndelangen self-assigned this Mar 25, 2019
@ndelangen
Copy link
Member

verified it locally and fixed it, can you confirm @joefraley ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants