New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix ts-lint config to lint tsx
files
#6533
Conversation
Also fix ts-lint errors due to its activation on `tsx` files
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-gaetanmaisse-fix-ts-linter.storybook.now.sh |
Codecov Report
@@ Coverage Diff @@
## next #6533 +/- ##
=======================================
Coverage 40.79% 40.79%
=======================================
Files 616 616
Lines 8525 8525
Branches 595 595
=======================================
Hits 3478 3478
Misses 4955 4955
Partials 92 92
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6533 +/- ##
=======================================
Coverage 40.79% 40.79%
=======================================
Files 616 616
Lines 8525 8525
Branches 595 595
=======================================
Hits 3478 3478
Misses 4955 4955
Partials 92 92
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch!
@gaetanmaisse do we need to patch this? it touches a bunch of files not present in |
@shilman no it's not needed, I think I misunderstood the |
Issue
NPM script for ts linter was:
yarn lint:ts **/*.ts **/.tsx
so it was not lintingtsx
files.What I did
I fixed this typo to
yarn lint:ts **/*.ts **/*.tsx
and I also fixed ts lint errors that appeared intsx
files.How to test
yarn lint
should not display any warning or error