Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ts-lint config to lint tsx files #6533

Merged
merged 1 commit into from Apr 16, 2019
Merged

chore: fix ts-lint config to lint tsx files #6533

merged 1 commit into from Apr 16, 2019

Conversation

gaetanmaisse
Copy link
Member

Issue

NPM script for ts linter was: yarn lint:ts **/*.ts **/.tsx so it was not linting tsx files.

What I did

I fixed this typo to yarn lint:ts **/*.ts **/*.tsx and I also fixed ts lint errors that appeared in tsx files.

How to test

  • CI should pass and yarn lint should not display any warning or error

Also fix ts-lint errors due to its activation on `tsx` files
@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 16, 2019
@vercel
Copy link

vercel bot commented Apr 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-gaetanmaisse-fix-ts-linter.storybook.now.sh

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #6533 into next will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6533   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         616      616           
  Lines        8525     8525           
  Branches      595      595           
=======================================
  Hits         3478     3478           
  Misses       4955     4955           
  Partials       92       92
Impacted Files Coverage Δ
lib/components/src/tabs/tabs.tsx 80.55% <ø> (ø) ⬆️
lib/components/src/tooltip/ListItem.tsx 91.42% <ø> (ø) ⬆️
lib/components/src/bar/separator.tsx 0% <0%> (ø) ⬆️
lib/components/src/ActionBar/ActionBar.stories.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34aa90d...5c476cb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #6533 into next will not change coverage.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6533   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         616      616           
  Lines        8525     8525           
  Branches      595      595           
=======================================
  Hits         3478     3478           
  Misses       4955     4955           
  Partials       92       92
Impacted Files Coverage Δ
lib/components/src/tabs/tabs.tsx 80.55% <ø> (ø) ⬆️
lib/components/src/tooltip/ListItem.tsx 91.42% <ø> (ø) ⬆️
lib/components/src/bar/separator.tsx 0% <0%> (ø) ⬆️
lib/components/src/ActionBar/ActionBar.stories.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34aa90d...5c476cb. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!

@shilman shilman merged commit fde572d into storybookjs:next Apr 16, 2019
@shilman shilman added this to the 5.0.x milestone Apr 16, 2019
@gaetanmaisse gaetanmaisse deleted the fix-ts-linter branch April 16, 2019 09:00
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 16, 2019
@shilman
Copy link
Member

shilman commented Apr 16, 2019

@gaetanmaisse do we need to patch this? it touches a bunch of files not present in master. removed the label for now, but can add it back if it's important

@gaetanmaisse
Copy link
Member Author

@shilman no it's not needed, I think I misunderstood the patch label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants