Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX null brandImage #6544

Merged
merged 1 commit into from
Apr 17, 2019
Merged

FIX null brandImage #6544

merged 1 commit into from
Apr 17, 2019

Conversation

kennethtruong
Copy link
Contributor

@kennethtruong kennethtruong commented Apr 17, 2019 •
edited by shilman
Loading

Issue: #5866

What I did

Make it so that brandImage is used if defined instead of null

(Addresses the issue introduced in #6120)

@vercel
Copy link

vercel bot commented Apr 17, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-kennethtruong-fix-nullbrandimage.storybook.now.sh

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch theming labels Apr 17, 2019
@shilman shilman added this to the 5.0.x milestone Apr 17, 2019
shilman
shilman approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kennethtruong ! Merging and will release

@shilman shilman merged commit eaff2e2 into storybookjs:next Apr 17, 2019
@shilman shilman mentioned this pull request Apr 17, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 18, 2019
shilman added a commit that referenced this pull request Apr 18, 2019
@shilman
Merge pull request #6544 from kennethtruong/fix/nullBrandImage
17026f5 
FIX null brandImage
@kennethtruong kennethtruong deleted the fix/nullBrandImage branch April 18, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch theming
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kennethtruong @shilman