BUGFIX v5.1.x change breaks Boolean knob (#6366) #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ES6 argument default value assignment to handle `undefined` case, which is never wanted; this prevent `false` cast to empty string (bug).
leoyli
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-bugfix-6366change-breaks-boolean-knob.storybook.now.sh |
|
Manually test in a staging environment (storybook official) was proven the bug fixed. PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6366
What I did
undefinedcase, which is never wanted; this preventfalsecast to empty string (bug).How to test
I have a strong feeling that we need to rewrite knob from the ground up with TS since it was too buggy. But I haven't talk with @ndelangen about what is the plan or roadmap for that yet...
And sorry for this easy bug I committed to fix lately, I get many things pile up unfortunately 馃槀...