Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field and variant comments to output #5

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

llogiq
Copy link

@llogiq llogiq commented Oct 12, 2020

No description provided.

Copy link

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge and then bump the submodule in pages

}

#[test]
fn doc_c_like_enum_variant() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not-blocking

Nice set of tests! It does make me wonder if we should compare against assets/fixtures in some cases to improve readability. Parsing all the line breaks on a large struct is not the easiest.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this in a followup.

@llogiq llogiq merged commit 28b827a into master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants