bitset: Improve performance of count function #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
count()
function of thebitset
container used two distinct reductions for computing the number of set bits. The first one considers all bits in the firstn - 1
block whereas the second one works on each of the remaining bits in then
-th block, i.e. the last block. Since the reduction is memory-bound anyways, the second reduction introduces a large overhead while the first one still has room for additional compute operations. Merge both reductions into a single one that computes a bit mask for each block on the fly before counting the bits per block. This leads to a decent performance improvement forcount()
and all related functions.Before:
After: