Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Use shorter inline variables for detail type traits #335

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

stotko
Copy link
Owner

@stotko stotko commented Oct 30, 2022

While the use of type traits from the C++ standard library have been simplified in #333, our own implementation-specific traits are still referenced by the classic *::value notation. Port these traits to the newer *_v versions as well for consistency and better readability.

Partially addresses #314

@stotko stotko added this to the 2.0.0 milestone Oct 30, 2022
@stotko stotko changed the title src,test: Use shorter inline variables for detail type traits src: Use shorter inline variables for detail type traits Oct 30, 2022
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 97.14% // Head: 97.14% // No change to project coverage 👍

Coverage data is based on head (0ec3ad2) compared to base (aecccfd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          32       32           
  Lines        2346     2346           
=======================================
  Hits         2279     2279           
  Misses         67       67           
Impacted Files Coverage Δ
src/stdgpu/impl/unordered_base.cuh 100.00% <ø> (ø)
src/stdgpu/impl/unordered_base_detail.cuh 96.00% <ø> (ø)
src/stdgpu/impl/unordered_map_detail.cuh 100.00% <ø> (ø)
src/stdgpu/impl/unordered_set_detail.cuh 100.00% <ø> (ø)
src/stdgpu/impl/vector_detail.cuh 94.00% <ø> (ø)
src/stdgpu/unordered_map.cuh 100.00% <ø> (ø)
src/stdgpu/unordered_set.cuh 100.00% <ø> (ø)
src/stdgpu/vector.cuh 100.00% <ø> (ø)
src/stdgpu/impl/memory_detail.h 99.03% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stotko stotko merged commit ce7281d into master Oct 30, 2022
@stotko stotko deleted the detail_inline_variables branch October 30, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant