Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Disable empty inherited footer #395

Merged
merged 1 commit into from
Aug 9, 2023
Merged

docs: Disable empty inherited footer #395

merged 1 commit into from
Aug 9, 2023

Conversation

stotko
Copy link
Owner

@stotko stotko commented Aug 9, 2023

The sphinx-book-theme is built upon the pydata theme and inherits many useful properties from it. However, the inherited footer is always empty as a dedicated one is already rendered at the bottom of each page. Disable the empty inherited footer to get rid of the page-wide 1px line drawn at the bottom.

@stotko stotko added this to the 2.0.0 milestone Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad7827b) 97.40% compared to head (e4e83e1) 97.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          31       31           
  Lines        2581     2581           
=======================================
  Hits         2514     2514           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit d9a4587 into master Aug 9, 2023
55 checks passed
@stotko stotko deleted the docs_empty_footer branch August 9, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant