Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more ide related folder to gitignore #412

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

tanzby
Copy link
Contributor

@tanzby tanzby commented Apr 8, 2024

This PR adds more IDE related folder to .gitignore folder

@tanzby
Copy link
Contributor Author

tanzby commented Apr 8, 2024

@stotko PTAL, thanks!

@stotko
Copy link
Owner

stotko commented Apr 8, 2024

Thanks for the contribution! I'm just wondering: Is @zubingtan a colleague of yours and you are submitting this change on behalf of him?

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (7b65f81) to head (a762b0f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   97.33%   97.37%   +0.03%     
==========================================
  Files          31       31              
  Lines        2512     2512              
==========================================
+ Hits         2445     2446       +1     
+ Misses         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanzby
Copy link
Contributor Author

tanzby commented Apr 8, 2024

Thanks for the contribution! I'm just wondering: Is @zubingtan a colleague of yours and you are submitting this change on behalf of him?

fixed

@tanzby tanzby force-pushed the add_clangd_cache_folder_to_gitignore branch from 10f537c to 140213e Compare April 8, 2024 07:40
@tanzby tanzby force-pushed the add_clangd_cache_folder_to_gitignore branch from 140213e to a762b0f Compare April 8, 2024 07:41
@stotko stotko self-requested a review April 8, 2024 08:29
Copy link
Owner

@stotko stotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'm just wondering: Is @zubingtan a colleague of yours and you are submitting this change on behalf of him?

fixed

Thanks for clarifying this and updating the PR. LGTM.

@stotko stotko merged commit 8f25f66 into stotko:master Apr 8, 2024
61 checks passed
@stotko stotko added this to the 2.0.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants