unordered_map,unordered_set: Simplify excess list size computation #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 31 31
Lines 2512 2512
=======================================
Hits 2446 2446
Misses 66 66 ☔ View full report in Codecov by Sentry. |
stotko
force-pushed
the
excess_count_simplify
branch
from
202c516
to
5062aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #414, the excess list size computation has been fixed for very low capacities. However, the use of
std::maxis not needed anymore due to the fix. Remove this expression to simplify the computation of the size.While at it, also make the estimate for the expected collisions slightly more conservative by always rounding up the computed value.