Failing specs fix and added support for modules #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. version 2.9 to 2.9.1
Most libraries are released as modules and would need this.
stouset
added a commit
that referenced
this pull request
Apr 29, 2011
Failing specs fix and added support for modules
|
Thanks! Merged and pushed as version 0.10.0. The only thing I want to change before releasing 1.0 is to have prerelease versions bump the major, minor, or revision number, if it's not already a prerelease. Right now, it bumps |
|
Thanks for being so quick to merge the changes. You're making it so much easier for me, I can now use the 0.10.0 instead of relying on a locally built gem. |
|
No problem. I really appreciate the high-quality patch. All the tests passed and the coding style matched mine. I love getting pull requests like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.