Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Consider remove EventSource object from IEventData #113

Closed
osoykan opened this issue Dec 5, 2017 · 1 comment
Closed

Consider remove EventSource object from IEventData #113

osoykan opened this issue Dec 5, 2017 · 1 comment
Assignees
@osoykan
Labels
enhancement
Milestone
2.3.0

Comments

@osoykan
Copy link
Member

osoykan commented Dec 5, 2017 •
edited

If we push events to RabbitMq or other messaging systems, EventSource won't be deserialized properly or getting exception since it is a proxied object. Event publisher already knows that where the Event published and why. Thus we can remove it.
@osoykan osoykan added this to the 2.3.0 milestone Dec 5, 2017
@osoykan osoykan self-assigned this Dec 5, 2017
osoykan pushed a commit that referenced this issue Dec 5, 2017
@trendyol-bot
EventSource remove for #113
6cd08f3
@osoykan
Copy link
Member Author

osoykan commented Dec 5, 2017

closed with 6cd08f3

@osoykan osoykan closed this as completed Dec 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@osoykan osoykan

Labels
enhancement
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@osoykan