Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error while versioning iOS #52

Open
aruldd opened this issue May 28, 2018 · 24 comments
Open

Syntax Error while versioning iOS #52

aruldd opened this issue May 28, 2018 · 24 comments

Comments

@aruldd
Copy link

aruldd commented May 28, 2018

PS F:\Shared Desktop\ROBOCRAZE\RnD\alphacare\hospital_app_react> yarn version --minor
yarn version v1.6.0
warning ..\package.json: No license field
info Current version: 0.1.0-beta
question New version:
error Invalid semver version
question New version: 0.2.0
info New version: 0.2.0
$ react-native-version
[RNV] Versioning Android...
[RNV] Android updated
[RNV] Versioning iOS...
[RNV] SyntaxError: Expected """, "\'", "\"", "\n", or [^\\"] but "\" found.

After setting up post version hook, running the command yarn version --minor produces this error.

Platform: Windows 10

@stovmascript
Copy link
Owner

Looks similar to: #38 (comment) and: #38 (comment)

@stovmascript
Copy link
Owner

@aruldd Is it possible you have manually set up some paths in your Xcode project file?

@VinceBT
Copy link

VinceBT commented May 30, 2018

Found the issue, the problem comes from React Native made in Windows that will have backslashed paths inside pbxproj. It's not a problem from your package at all @stovmascript .
Check strings that are like this:

"\"$(SRCROOT)/$(TARGET_NAME)\"",
or
"$(SRCROOT)\..\node_modules\react-xxxx",

and change them to

"$(SRCROOT)/$(TARGET_NAME)",
accordingly
"$(SRCROOT)/../node_modules/react-xxxx",

@stovmascript
Copy link
Owner

@VinceBT Awesome, I'll capture this message and print out something more meaningful.

@stovmascript
Copy link
Owner

stovmascript commented May 31, 2018

@VinceBT I also suspect that it's more of an issue with react-native link because a newly initialized project doesn't have any $(SRCROOT) strings yet. Which would explain why everything worked for me in: #38 (comment).

@VinceBT
Copy link

VinceBT commented May 31, 2018

It's just because Windows uses \ instead of / for paths and when paths are written to pbxproj when using react-native link, they will contain backslashes, it still works when your compile on a Mac, but it will crash with the pbxproj-dom parser package that you use. You could maybe add a "Common issues" page on your README for future users.

@VinceBT
Copy link

VinceBT commented Jun 1, 2018

@aruldd Tell us if it worked for you so @stovmascript can close

stovmascript added a commit that referenced this issue Jun 4, 2018
Fix #52 Add "Known issues" to README
@Maushundb
Copy link

I'm getting this issue when running on Mac OSX, is that expected? I'm on 3.2.0

@Maushundb
Copy link

Yeah there seems to be some paths in pbxproj that cocoapods installs that has the windows syntax as well. Had to go in and edit them manually, now it works. This does happen on macs as well apparently, might wanna update docs.

@stovmascript
Copy link
Owner

Hmm, this seems like a bug with cocoapods, or even some specific packages. I'm wondering if we could find the offending upstream code and report it...

@stovmascript
Copy link
Owner

stovmascript commented Nov 26, 2019

Or we could patch pbxproj-dom or find an alternative.

@Maushundb
Copy link

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

@stovmascript stovmascript reopened this Nov 27, 2019
@vladwhd
Copy link

vladwhd commented Jan 24, 2020

I have a more "funny" case. My error was "SyntaxError: Expected """, "\'", "\"", "\n", or [^\\"] but "\" found.", so I searched for \ in the project.pbxproj and the only place where it was present was

shellScript = "# Name of the resource we're selectively copying\nFILENAME=GoogleService-Info.plist\n\nBUILD_TYPE=$(echo ${CONFIGURATION} | sed -E \"s/\\s*(Release|Debug) \\s*//\")\nORIGINAL_PATH=${PROJECT_DIR}/${TARGET_NAME}/Firebase/${BUILD_TYPE}/${FILENAME}\nDESTINATION_DIR=${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app\n\n# Make sure the prod version of GoogleService-Info.plist exists\necho \"Looking for ${ORIGINAL_PATH}\"\nif [ ! -f $ORIGINAL_PATH ]\nthen\n echo \"No ${FILENAME} found for build type ${BUILD_TYPE}. Please ensure it's in the proper directory.\"\n exit 1\nfi\n\necho \"Will copy ${ORIGINAL_PATH} to final destination: ${DESTINATION_DIR}\"\n\ncp \"${ORIGINAL_PATH}\" \"${DESTINATION_DIR}\"\n";

So basically it failed parsing the shell script, which is kind of weird. I removed this script and the error was gone, so it's this indeed.
I will change my script to fix this, but it shouldn't have happened in the first place.

@fabricio0915
Copy link

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

your command line appers like this?

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \n../node_modules/react-native/scripts/react-native-xcode.sh\n";

@sanjaypojo
Copy link

sanjaypojo commented May 19, 2020

Facing the same problem after adding a custom build script, have been using the library without any issues for a year, but stuck now. Lots of backslashes in the script to escape quotes and spaces, so not sure how to fix it.

EDIT: I've created an issue in pbxproj-dom to see if they have any ideas on a fix

@sanjaypojo
Copy link

sanjaypojo commented May 28, 2020

Just to clarify though -- I'm facing this issue on macOS. Here's the exact error:

[RNV] SyntaxError: Expected ",", "/*", or [ \t\n\r] but "B" found.

EDIT: Managed to resolve the issue by checking through my build settings and removing some \ characters as suggested

@otkach-yara
Copy link

I have fixed this issue by moving the script, which caused the error, from project.pbxproj to separate .sh file and then just added a reference to that file. Also you should make your sh file executable by chmod +x script.sh

Screenshot 2021-05-18 at 17 53 52

@bimusiek
Copy link

In our case it was newest react with @sentry/react-native having offending lines in shell script (copied from official Sentry documentation about workaround for RN >0.69)
Here is the working shell script line in case anyone needs it:

/bin/sh -c "$WITH_ENVIRONMENT '$SENTRY_CLI_PATH react-native xcode $REACT_NATIVE_XCODE'"

@marcinniemirski
Copy link

Here is the final version of working shellScript in Sentry v5 and RN v0.71

shellScript = "set -e\nexport SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\nSENTRY_CLI_PATH=\"../node_modules/@sentry/cli/bin/sentry-cli\"\n/bin/sh -c \"$WITH_ENVIRONMENT $SENTRY_CLI_PATH react-native xcode\n$REACT_NATIVE_XCODE\"\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";

@n-ii-ma
Copy link

n-ii-ma commented Jun 13, 2023

I'm experiencing this issue with Sentry.

I suspect this line is causing the problem, but I don't know how to fix it:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nset -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE\\\"\"\n\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";

Any way to solve this?

@alainib
Copy link

alainib commented Aug 23, 2023

i have the same error on MacOs now. any one fixed this please ?

@erickgtzh
Copy link

i have the same error on MacOs now. any one fixed this please ?

were you able to fix it?

@29er
Copy link

29er commented Oct 20, 2023

SyntaxError: Expected """, "\'", "\"", "\n", or [^\\"] but "\" found.

similar to above it was Sentry shell script. I am on a mac.
shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport ....."

in several places I had to replace $WITH_ENVIRONMENT \\\ with $WITH_ENVIRONMENT \ and $REACT_NATIVE_XCODE\\\ with $REACT_NATIVE_XCODE\

@Leslie-Wong-H
Copy link

Faced the same issue with Mac. Resolved with changing

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target\\ Support\\ Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

to

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target' 'Support' 'Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

The key: \\ to ' '
Root reason - the file path with space in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests