Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added detection for properties managed by enviromental variables #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added detection for properties managed by enviromental variables #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ function isExpoProject(projPath) {
}
}

/**
* Determine if the given property is managed by an enviromental variable
* @param {String} text
* @return {Boolean} true if the given property is managed by an enviromental variable
*/
function isManagedByEnvVariable(propertyText) {
return propertyText ? !!/\$\(\S+\)/g.exec(propertyText) : false;
}

/**
* Versions your app
* @param {Object} program commander/CLI-style options, camelCased
Expand Down Expand Up @@ -431,7 +440,8 @@ function version(program, projectPath) {
CFBundleShortVersionString: appPkg.version
}
: {},
!programOpts.neverIncrementBuild
!programOpts.neverIncrementBuild &&
!isManagedByEnvVariable(json.CFBundleVersion)
? {
CFBundleVersion: getNewVersionCode(
programOpts,
Expand Down