Removed the disgusting MERGE_STATIC_LIBRARIES and all uses of it. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when libstp is built the boost-library will not be merged in to it. CMake clients of libstp * the stp executable * Any CMake project that imports our targets will automatically know which Boost libraries to link in. Clients of libstp (e.g. KLEE )who do not use CMake will now have to link in the right Boost libraries manually to their application
|
Passed Travis build, so merging. |
delcypher
added a commit
that referenced
this pull request
Jan 25, 2014
Removed the disgusting MERGE_STATIC_LIBRARIES and all uses of it.
This was referenced Jan 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when libstp is built the boost-library will not be merged in to
it. CMake clients of libstp
will automatically know which Boost libraries to link in.
Clients of libstp (e.g. KLEE )who do not use CMake will now have to link
in the right Boost libraries manually to their application
I have a pull request which adds support this change in KLEE