Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Python 3.11, move configs to submodule #18

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 23, 2023

I think the top-level configs.py file may cause some packaging problems in general. Moved to the pytest_retry folder where its less likely to conflict with other packages.

Closes #17

@str0zzapreti str0zzapreti added the bug Something isn't working label Aug 23, 2023
Copy link
Owner

@str0zzapreti str0zzapreti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely caused by the location of the configs file rather than anything to do with Python 3.11, I can replicate the issue locally. I would've expected the same error on the new version with pip install -e, but Python... uh, finds a way.

@str0zzapreti str0zzapreti merged commit c91cc3d into str0zzapreti:main Aug 23, 2023
6 checks passed
@tswast
Copy link
Contributor Author

tswast commented Aug 24, 2023

Thanks for the quick review @str0zzapreti

@str0zzapreti
Copy link
Owner

Sure thing @tswast, thanks for taking the time to make a PR. I never really expected this plugin to get any use outside of my own work, but it's really gratifying to see other people take an interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fails with latest version of pytest on Python 3.11
2 participants