Relax the constraint and allow for transactions to be replaced. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
reviewed
Feb 5, 2020
| @@ -94,8 +94,7 @@ pub fn init_data_database<P: AsRef<Path>>(db_data: P) -> Result<(), Error> { | |||
| spent INTEGER, | |||
| FOREIGN KEY (tx) REFERENCES transactions(id_tx), | |||
| FOREIGN KEY (account) REFERENCES accounts(account), | |||
| FOREIGN KEY (spent) REFERENCES transactions(id_tx), | |||
| CONSTRAINT tx_output UNIQUE (tx, output_index) | |||
| FOREIGN KEY (spent) REFERENCES transactions(id_tx) | |||
There was a problem hiding this comment.
I'm still not convinced that this is a correct change, and that there's a bug somewhere else. But if it fixes a known problem then it will do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to the bug we saw where Brad/Geffen's devices were getting stuck, constantly crashing. Per our discussions, it should be safe to remove this constraint.