ci: ensure tests fail build

straker · Aug 11, 2020 · 67cd798 · 67cd798
1 parent 9c9db3c
commit 67cd798
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/test/permutations/index.js b/test/permutations/index.js
@@ -105,10 +105,10 @@ Object.keys(options).forEach(async (option) => {
       fs.writeFileSync(path.join(__dirname, `${option}.spec.js`), contents, 'utf-8');
 
       execSync('npx karma start ' + path.join(__dirname, 'karma.conf.js'), {stdio: 'inherit'});
-    } catch(e) {
-      // for some reason a failing test/exec does not error the program
-      console.log(e);
-      return process.exit(1);
     }
+  } catch(e) {
+    // for some reason a failing test/exec does not error the program
+    console.log(e);
+    return process.exit(1);
   }
 });
diff --git a/test/unit/sprite.spec.js b/test/unit/sprite.spec.js
@@ -114,11 +114,11 @@ describe('sprite with context: ' + JSON.stringify(testContext,null,4), () => {
       let sprite = Sprite({
           x: 10,
           y: 20,
-          advance: sinon.spy();
+          advance: sinon.spy()
         });
         sprite.update();
 
-        expect(sprite.advance.called).to.be.true;
+        expect(sprite.advance.called).to.be.false;
     });
 
     if (testContext.SPRITE_ANIMATION) {