Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix axelar #102

Merged
merged 2 commits into from
Feb 27, 2023
Merged

fix axelar #102

merged 2 commits into from
Feb 27, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Feb 27, 2023

make generate was causing axelar build issues. This is an unnecessary step as it is used to generate mocks for tests and docs, which aren't needed for the runtime binary.

Resolves #94

@agouin agouin requested a review from DavidNix February 27, 2023 05:02
DavidNix
DavidNix approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unnecessary step as it is used to generate mocks for tests and docs, which aren't needed for the runtime binary.

I hoped so! But I didn't want to assume as I was scrambling to get the build working during an upgrade.

@DavidNix DavidNix mentioned this pull request Feb 27, 2023
Merged
@agouin agouin changed the base branch from andrew/basic_auth to main February 27, 2023 16:19
@agouin agouin merged commit 4e75942 into main Feb 27, 2023
@agouin agouin deleted the andrew/fix_axelar branch February 27, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNix DavidNix DavidNix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axelar fails to build due to new golangci-lint prereq
2 participants
@agouin @DavidNix