Wasmvm version awk should pull the last field #143
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures a replace in go.mod will pull the correct version.
|
Great fix, @misko9! And, interesting they needed the replace because of transitive dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabs the last field of wasmvm version grepped instead of the 2nd. This ensures a replace in go.mod will pull the correct version.
I noticed the latest osmosis builds do not work because wasmvm v1.1.1 is downloaded instead of v1.1.2. Here is the error:
Error: libwasmversion mismatch. got: 1.1.1; expected: v1.1.2
You can see the replace here along with the security advisory. For indirect dependencies, the advisory recommends using a replace, so this commit could be required for more chains following that guidance too:
https://github.com/osmosis-labs/osmosis/blob/v15.1.2/go.mod#L314