Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sei config in chains.yaml #146

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Jul 7, 2023

Description

This updates the sei chains.yaml config to better reflect changes that have been made in the sei build process more recently.

Testing

Tested by building sei image with the commands and verified that the binary is runnable in the container

./heighliner build -c sei -g 3.0.5
docker run -it --rm --entrypoint sh sei:3.0.5

chains.yaml Outdated
@@ -871,20 +871,12 @@
dockerfile: cargo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to change this to cosmos now without the shared library requirement so that we get a fully static binary

@udpatil udpatil requested a review from agouin July 10, 2023 18:25
@udpatil
Copy link
Contributor Author

udpatil commented Jul 10, 2023

@agouin I updated to use the cosmos dockerfile for static binary. lmk if this looks good, and I'll need your help to run the workflow for CI

Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update! I'm happy we can build it as a standard cosmos chain now.

@agouin agouin merged commit e3a5df6 into strangelove-ventures:main Jul 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants