Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status check to ensure we gracefully discontinue #158

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add status check to ensure we gracefully discontinue #158

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a0f1aa
Add status check to ensure we gracefully discontinue
vimystic Jul 27, 2023
4575a7a
Update log message to reflect status code and message if any
vimystic Jul 27, 2023
88262a5
Split err and status checks to avoid a null dereference error
vimystic Jul 27, 2023
7449c40
Adress new line warning on gostatic check
vimystic Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func mostRecentReleasesForChain(
number int16,
) (builder.HeighlinerQueuedChainBuilds, error) {
if chainNodeConfig.GithubOrganization == "" || chainNodeConfig.GithubRepo == "" {
return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("github organization: %s and/or repo: %s not provided for chain: %s\n", chainNodeConfig.GithubOrganization, chainNodeConfig.GithubRepo, chainNodeConfig.Name)
return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("github organization: %s and/or repo: %s not provided for chain: %s", chainNodeConfig.GithubOrganization, chainNodeConfig.GithubRepo, chainNodeConfig.Name)
}
client := http.Client{Timeout: 5 * time.Second}

Expand All @@ -47,6 +47,9 @@ func mostRecentReleasesForChain(
if err != nil {
return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("error performing github releases request: %v", err)
}
if res.StatusCode != http.StatusOK {
return builder.HeighlinerQueuedChainBuilds{}, fmt.Errorf("status code: %v", res.StatusCode)
}

defer res.Body.Close()

Expand Down
Loading