Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add du to images #26

Merged
merged 4 commits into from
Sep 6, 2022
Merged

feat: Add du to images #26

merged 4 commits into from
Sep 6, 2022

Conversation

DavidNix
Copy link
Contributor

@DavidNix DavidNix commented Sep 1, 2022

I missed this today. Unfortunately, k8s doesn't easily let you see Volume used disk space, only the capacity.

I don't think du is a security risk. If so, please close this PR with a reason (so I'm educated!).

@agouin
Copy link
Member

agouin commented Sep 2, 2022

I think including du is warranted! We will also need to include it in the busybox config so it is built.

# CONFIG_DU is not set

Copy link
Member

@danbryan danbryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets du it!

@DavidNix
Copy link
Contributor Author

DavidNix commented Sep 6, 2022

@agouin Hope I enabled it correctly!

@DavidNix DavidNix merged commit 2cbfc73 into main Sep 6, 2022
@DavidNix DavidNix deleted the nix/feat/add-du branch September 6, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants