Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain info for tofnd #69

Merged
merged 2 commits into from
Jan 9, 2023
Merged

chain info for tofnd #69

merged 2 commits into from
Jan 9, 2023

Conversation

danbryan
Copy link
Member

@danbryan danbryan commented Jan 8, 2023

added tofnd to heighliner

@danbryan danbryan self-assigned this Jan 8, 2023
Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbryan
Copy link
Member Author

danbryan commented Jan 9, 2023

@agouin this conflicts with your PR, not gonna merge till we chat

@agouin
Copy link
Member

agouin commented Jan 9, 2023

@agouin this conflicts with your PR, not gonna merge till we chat

#70 is a PR into this branch, so no conflicts here. But as I posted in slack, this does not build for me on arm64, and I'd rather not use pre-build to do the build when we can go through the heighliner process with the addition of --recursive to the Dockerfile clones.

* Recursive clone in Dockerfiles, use build target for tofnd

* Remove debug line
@danbryan danbryan merged commit a581abb into main Jan 9, 2023
@danbryan danbryan deleted the danb/tofnd branch January 9, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants