Accept empty build-targets and add Carbon Chain
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojamya
changed the title
build-targetsbuild-targets and add Carbon Chain
|
Whoops, did not mean to delete this. Restoring. |
|
Closing. Will open separate PR to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heighliner accepts empty build-targets. Necessary for running prebuilt binaries.
Also addresses copying installed libraries into a folder where the "heighliner" user doesn't need
sudo.@agouin I tried to replicate what we did in rust/native.Dockerfile across the other docker files. I'm sure I missed something. Give it a good look over.