Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize wasm version check #71

Merged
merged 2 commits into from
Jan 9, 2023
Merged

optimize wasm version check #71

merged 2 commits into from
Jan 9, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Jan 9, 2023

Only check final versions of libs for wasm version check. This reduces the time to check for the wasm version when building the Dockerfile significantly.

https://stackoverflow.com/questions/59196227/find-version-of-a-module#answer-59244274

@agouin agouin requested a review from misko9 January 9, 2023 22:36
@agouin agouin merged commit 9d25372 into main Jan 9, 2023
@agouin agouin deleted the andrew/wasm_version_only_final branch January 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants