Add sei chain #99
Merged
Add sei chain #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNix
approved these changes
Feb 27, 2023
Comment on lines
+149
to
+156
| RUN bash -c 'set -eux;\ | ||
| i=0; for BIN in /root/bin/*; do\ | ||
| echo "Getting $(uname -m) libs for bin: $BIN";\ | ||
| readarray -t LIBS < <(ldd "$BIN");\ | ||
| for LIB in "${LIBS[@]}"; do\ | ||
| PATH1=$(echo $LIB | awk "{print \$1}");\ | ||
| if [ "$PATH1" = "linux-vdso.so.1" ]; then continue; fi;\ | ||
| PATH2=$(echo $LIB | awk "{print \$3}");\ |
There was a problem hiding this comment.
No change now. But I had a thought. I bet these long bash commands will be easier to read if in a .sh or .bash file that's copied into the container. We'd get IDE syntax highlighting, for example.
There was a problem hiding this comment.
Good call. Will handle that as a follow up
agouin
added a commit
that referenced
this pull request
Feb 27, 2023
* Add Sei chain * wip * Move to cargo build strategy * Update chains.yaml * Integrate optional go install/build into cargo dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -euxto all dockerfile script steps to catch any errors along the way instead of proceeding past them.