Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature and timestamp to log for adjusted timestamp visibility #118

Merged
merged 3 commits into from Nov 13, 2022

Conversation

chillyvee
Copy link
Contributor

Description

Seeing Horcrux logs sending signatures to multiple nodes visually appears to be potentially a Double Sign.

Print the vote signature prefix and timestamp to show the result provided is the same to reduce human operator panic.

Moved node to the end for easy visual checks of signature equality

Checklist

  • I have made sure the upstream branch for this PR is correct
  • I have made sure this PR is ready to merge
  • I have made sure that I have assigned reviewers related to this project

Changes

  • Added signature and timestamp logging

Screenshots

Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PREVOTE sig=4F709E6B9AE7 ts=1667684648 node=tcp://10.1.1.1:1111
Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PREVOTE sig=4F709E6B9AE7 ts=1667684648 node=tcp://10.1.1.1:1112
Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PREVOTE sig=4F709E6B9AE7 ts=1667684648 node=tcp://10.1.1.1:1113
Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PRECOMMIT sig=00DB7E882197 ts=1667684648 node=tcp://10.1.1.1:1111
Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PRECOMMIT sig=00DB7E882197 ts=1667684648 node=tcp://10.1.1.1:1112
Signed vote                                  module=validator height=653101 round=0 type=SIGNED_MSG_TYPE_PRECOMMIT sig=00DB7E882197 ts=1667684648 node=tcp://10.1.1.1:1113
...

@agouin
Copy link
Member

agouin commented Nov 6, 2022

Thank you for this @chillyvee ! If you fix the line length lint error we can get this merged.

@chillyvee
Copy link
Contributor Author

Lint reports green now. Thank you @agouin

@agouin agouin merged commit 5c4303c into strangelove-ventures:main Nov 13, 2022
agouin pushed a commit that referenced this pull request Nov 13, 2022
…118)

* Add signature and timestamp to log for adjusted timestamp visibility

* Reduce line length

* Handle empty Signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants