Widget Login Form Issues #2335
Merged
Widget Login Form Issues #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### All Submissions: * [x] Have you followed the [Contributing guideline](CONTRIBUTING.MD)? * [x] Does your code follow the [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/)? * [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change? <!-- Mark completed items with an [x] --> <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Changes proposed in this Pull Request: Adjusted sanitization around the widget login form as multiple layers of escaping resulted in the fields being removed. ### How to test the changes in this Pull Request: 1. Add the Login Widget to a sidebar or widget field 2. The login form fields should still show and work as expected ### Other information: * [x] Have you added an explanation of what your changes do and why you'd like us to include them? * [x] Have you successfully run tests with your changes locally? <!-- Mark completed items with an [x] --> ### Changelog entry Improvements to escaping contents of login form widget
This reverts commit d5d9f47.
This reverts commit 5ab7e22.
This reverts commit 530eeb0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adjusted sanitization around the widget login form as multiple layers of escaping resulted in the fields being removed.
How to test the changes in this Pull Request:
Other information:
Changelog entry
Improvements to escaping contents of login form widget