Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cancel page to be a nonced form with new actions #2839

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The goal of these changes is to allow Add Ons (Such as the Reason For Cancelling Add On) and custom code to easily hook into the cancel page.

Added new actions:

  • pmpro_cancel_before_submit
  • pmpro_cancel_should_process
  • pmpro_cancel_processed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 added this to the 3.0 milestone Feb 13, 2024
@dparker1005
Copy link
Member Author

The diff looks messy due to fixed indentation. This may break backwards compatibility for custom page templates, but this is why it is important to release in a major version. It also adds new filters which should help avoid the need for custom templates going forwards.

@ideadude ideadude merged commit 9bdf125 into strangerstudios:v3.0 Feb 16, 2024
@dparker1005 dparker1005 deleted the cancel-page-form branch February 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants