Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow developers to include a custom preheader file in their theme #66

Closed
wants to merge 1 commit into from

Conversation

roccotripaldi
Copy link

Take a look. I've tried this out on one site and it works well.

@strangerstudios
Copy link
Collaborator

Rocco, this is cool, but I'd rather not allow developers to override the entire preheader files. It is more likely to break functionality with future version of the plugin than editing the pages/... template files.

The better thing to do would be to figure out specifically what you want to override and add a hook/filter there (or a few hooks/filters) to let you do the customization you want to do.

So let me know what you wanted to do here.

Hope this makes sense.

@roccotripaldi
Copy link
Author

That makes sense. I posted my issues in the plugin's forums. I will attempt to solve the problems with hooks.

@scottsousa
Copy link
Contributor

Link to post for reference: http://wordpress.org/support/topic/custom-preheaders

@strangerstudios
Copy link
Collaborator

Follow up there (thanks for the link, Scott). Will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants