inject middleware instead of using router #75
Conversation
There was a problem hiding this comment.
Thinking about this it's gonna be basically impossible to cache plugin routes 🤔 because the plugins won't even be loaded yet let alone register their routes. Especially here where my redis plugin hasn't even ran yet unless I modify it I guess to run on register too? Not sure on the timing though as I basically need to get my plugin registered first.
| const { resolveUserStrategy } = require('./utils/config/resolveUserStrategy'); | ||
| const { injectMiddlewares } = require('./utils/middlewares/injectMiddlewares'); | ||
|
|
||
| const createProvider = async (providerConfig, { strapi }) => { |
There was a problem hiding this comment.
This needs to be moved back to bootstrap currently it will try to run this before the provider exists:
We can still register the middlewares but we can't create the provider until we get to the bootstrap.
|
Btw I fixed a bug you had with the contentType |
|
Tested moving my code in |
|
After doing some basic testing it works really well and custom additional route middlewares work perfectly 👍 |
|
Will make the provider change this evening |
|
Can't promise I'll have time to test this before I go on vacation but I'll try |
|
@derrickmehaffy @Boegie19 is there anything we can do to push this along? |
We will most likely wait for Strapi v5 to be released as it's gonna require an entire new rewrite most likely |
after talking to derrick this is my PR for chancing from router usage to injection usage.
Possible Breaking Change: ONLY strapi.api routes can be seen.
fixes: #65