refactor(config): add defaults #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JaydeeSale
commented
Feb 19, 2023
JaydeeSale
commented
- Adding default config for merging of plugins.ts config correctly as per strapi documentation on custom plugins
- Fix for uid failing when using custom controllers in strapi, that dont have content types defined
Check for UID on api service, if using custom controllers this will be null, and cause the library to be unusable for anything under than standard content types.
Adding in the default config, so that strapi can merge the transformer config correctly with out the default keys the values dont get merged in and the plugin doesn't register the middleware. as per https://docs.strapi.io/developer-docs/latest/setup-deployment-guides/configurations/optional/plugins.html#graphql-configuration config -> Optional Used to override default plugin configuration (defined in strapi-server.js)
Update register.js
Updating default config
When a custom controller is implemented, content types are not set.
|
@ComfortablyCoding can we get this in, so it works in the latest strapi versions |
|
I'll have a look at it over the weekend. |
|
Looks GTM!, I will add a fix for the custom controllers in a seperate PR to keep scope on a single fix/feat etc |
ComfortablyCoding
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.