fix: set dev-deps correctly so styled-components is not bundled

strapi · Apr 23, 2024 · f785c2c · f785c2c
1 parent d83898b
commit f785c2c
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 2 deletions.
diff --git a/.changeset/hip-roses-wash.md b/.changeset/hip-roses-wash.md
@@ -0,0 +1,7 @@
+---
+'@strapi/design-system': patch
+'@strapi/icons': patch
+'@strapi/ui-primitives': patch
+---
+
+fix: set dev dependencies correctly to avoid styled-components being bundled
diff --git a/packages/primitives/package.json b/packages/primitives/package.json
@@ -44,6 +44,8 @@
   },
   "devDependencies": {
     "@strapi/pack-up": "^5.0.0",
+    "react": "18.2.0",
+    "react-dom": "18.2.0",
     "rimraf": "^5.0.5",
     "typescript": "^5.4.4"
   },

diff --git a/packages/strapi-design-system/package.json b/packages/strapi-design-system/package.json
@@ -29,6 +29,8 @@
     "@types/react-router-dom": "^5.3.3",
     "@types/styled-components": "^5.1.26",
     "cross-env": "^7.0.3",
+    "react": "18.2.0",
+    "react-dom": "18.2.0",
     "rimraf": "^5.0.5",
     "styled-components": "^5.3.11",
     "typescript": "^5.4.4"

diff --git a/packages/strapi-icons/package.json b/packages/strapi-icons/package.json
@@ -31,11 +31,15 @@
   "devDependencies": {
     "@strapi/pack-up": "^5.0.0",
     "@svgr/cli": "8.1.0",
-    "rimraf": "^5.0.5"
+    "react": "18.2.0",
+    "react-dom": "18.2.0",
+    "rimraf": "^5.0.5",
+    "styled-components": "^5.3.11"
   },
   "peerDependencies": {
     "react": "^17.0.0 || ^18.0.0",
-    "react-dom": "^17.0.0 || ^18.0.0"
+    "react-dom": "^17.0.0 || ^18.0.0",
+    "styled-components": "^5.2.1"
   },
   "scripts": {
     "build": "yarn clean:generated && yarn generate:icons && yarn generate:symbols && yarn build:prod",

diff --git a/yarn.lock b/yarn.lock
@@ -5103,6 +5103,8 @@ __metadata:
     "@uiw/react-codemirror": ^4.21.25
     aria-hidden: ^1.2.4
     cross-env: ^7.0.3
+    react: 18.2.0
+    react-dom: 18.2.0
     react-remove-scroll: ^2.5.9
     rimraf: ^5.0.5
     styled-components: ^5.3.11
@@ -5152,10 +5154,14 @@ __metadata:
   dependencies:
     "@strapi/pack-up": ^5.0.0
     "@svgr/cli": 8.1.0
+    react: 18.2.0
+    react-dom: 18.2.0
     rimraf: ^5.0.5
+    styled-components: ^5.3.11
   peerDependencies:
     react: ^17.0.0 || ^18.0.0
     react-dom: ^17.0.0 || ^18.0.0
+    styled-components: ^5.2.1
   languageName: unknown
   linkType: soft
 
@@ -5215,6 +5221,8 @@ __metadata:
     "@radix-ui/react-visually-hidden": ^1.0.3
     "@strapi/pack-up": ^5.0.0
     aria-hidden: ^1.2.4
+    react: 18.2.0
+    react-dom: 18.2.0
     react-remove-scroll: ^2.5.9
     rimraf: ^5.0.5
     typescript: ^5.4.4