Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-system): main nav icons should be 1.6rem #1699

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Apr 23, 2024

What does it do?

  • changes the icon size in MainNav/NavLink to be 1.6rem instead of 1rem

Why is it needed?

  • visual issue

Related issue(s)/PR(s)

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Apr 23, 2024
@joshuaellis joshuaellis self-assigned this Apr 23, 2024
Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 83249e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Patch
@strapi/ui-primitives Patch
@strapi/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:00pm
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 4:00pm

Copy link

Size Change: -32 B (0%)

Total Size: 490 kB

Filename Size Change
packages/strapi-design-system/dist/index.js 195 kB -17 B (0%)
packages/strapi-design-system/dist/index.mjs 194 kB -15 B (0%)
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB
packages/strapi-icons/dist/index.js 22.1 kB
packages/strapi-icons/dist/index.mjs 21.7 kB
packages/strapi-icons/dist/symbols-index.js 12 kB
packages/strapi-icons/dist/symbols-index.mjs 11.9 kB

compressed-size-action

@joshuaellis joshuaellis merged commit 9fdfdde into releases/2.0.0 Apr 24, 2024
7 checks passed
@joshuaellis joshuaellis deleted the fix/main-nav-icon-size branch April 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants