Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove cms specific components #1703

Merged
merged 1 commit into from
May 7, 2024

Conversation

madhurisandbhor
Copy link
Collaborator

@madhurisandbhor madhurisandbhor commented Apr 25, 2024

What does it do?

  • Removed CMS specific components. with new design system V2, we are moving any specific CMS specific component to its own package as DS expands to cloud as well.

Related Issues

  • resolves DX-1381

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 41c7e7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 🛑 Canceled (Inspect) May 7, 2024 8:44am
design-system 🛑 Canceled (Inspect) May 7, 2024 8:44am
design-system-website 🛑 Canceled (Inspect) May 7, 2024 8:44am

Copy link

github-actions bot commented Apr 25, 2024

Size Change: -2.57 kB (-1%)

Total Size: 294 kB

Filename Size Change
packages/design-system/dist/index.js 97.6 kB -1.31 kB (-1%)
packages/design-system/dist/index.mjs 96.2 kB -1.26 kB (-1%)
ℹ️ View Unchanged
Filename Size
packages/icons/dist/index.js 22.1 kB
packages/icons/dist/index.mjs 21.7 kB
packages/icons/dist/symbols-index.js 11.9 kB
packages/icons/dist/symbols-index.mjs 11.8 kB
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB

compressed-size-action

@madhurisandbhor madhurisandbhor self-assigned this Apr 25, 2024
@madhurisandbhor madhurisandbhor added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package flag: 💥 Breaking change This PR contains breaking changes and should not be merged labels Apr 25, 2024
@madhurisandbhor madhurisandbhor marked this pull request as ready for review April 25, 2024 08:21
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a more comprehensive changeset about which components specifically were removed? Also lets not forget to add these to the BREAKING_CHANGES doc :)

Also before this is merged we need to make the opposite PR in the CMS that copies over the components 💪🏼

fix: removed hooks used for headerLayout

docs: breaking changes updated, changeset updated
@joshuaellis joshuaellis force-pushed the chore/remove-cms-components branch from d56908f to 41c7e7a Compare May 7, 2024 08:38
@joshuaellis joshuaellis merged commit 54ebfad into releases/2.0.0 May 7, 2024
6 of 8 checks passed
@joshuaellis joshuaellis deleted the chore/remove-cms-components branch May 7, 2024 08:43
joshuaellis added a commit that referenced this pull request May 9, 2024
this should have been removed in #1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants